2010/1/26 Peter Eisentraut <pete...@gmx.net>: > On tis, 2010-01-19 at 01:01 +0900, Hitoshi Harada wrote: >> I reviewed this patch today. > > Thank you for this very thorough and helpful review. Comments below and > a new patch attached. > OK, I confirmed all the issues relevant to the patch were fixed. I'm not so familiar with transaction detail, so I leave it as a known issue.
I found ereport() in MergeAttributes() should be indented but except for that there's no issue. So I think I've done my review. > I have a follow-up patch that I haven't been able to finish that adds > ALTER TYPE stuff to do add/dropping/renaming on the type. I will submit > it once we get this patch finalized and I find some time. I'll look at it when it's ready. Regards, -- Hitoshi Harada -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
