Fujii Masao wrote: > On Sun, Feb 7, 2010 at 1:02 AM, Bruce Momjian <br...@momjian.us> wrote: >>> src/backend/access/transam/xlog.c >>>> else >>>> { >>>> XLogRecPtr InvalidXLogRecPtr = {0, 0}; >>>> ControlFile->minRecoveryPoint = InvalidXLogRecPtr; >>>> } >>> In my original patch, the above is for the problem discussed in >>> http://archives.postgresql.org/pgsql-hackers/2009-12/msg02039.php >>> >>> Since you've already fixed the problem, that code is useless. >>> How about getting rid of that code? >> Has this been addressed? > > No. We need to obtain the comment about that from Heikki.
I removed that. It only makes a difference if you stop archive recovery, remove recovery.conf, and start up again, causing the server to do normal crash recovery. That's a "don't do that" scenario, but it seems better to not clear minRecoveryPoint, even though we don't check it during crash recovery. It might be useful debug information, and also if you then put recovery.conf back, we will enforce that you reach the minRecoveryPoint again. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers