On Tue, Mar 30, 2010 at 9:48 PM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Wed, Mar 31, 2010 at 9:47 AM, Robert Haas <robertmh...@gmail.com> wrote: >> On Tue, Mar 30, 2010 at 5:09 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >>> I rebased the patch to HEAD. Is the patch still required for 9.0? >>> If not, I'd remove the open item of the smart shutdown during >>> recovery. >> >> I am by no means an expert on this area of the code, but in the >> interest of moving things along I reviewed this patch tonight. > > Thanks a lot! > >> 1. I wonder if there is a problem if we receive SIGINT while in the >> PM_WAIT_READONLY state? Seems to me that might need to be added to >> the if statement beginning at line 2212, in pmdie(). >> >> 2. It appears to me that HandleChildCrash() needs to switch to >> PM_WAIT_BACKENDS state if it's in PM_WAIT_READONLY when the child >> crash occurs - i.e. the if statement beginning at line 2772 needs >> updating. >> >> Thoughts? > > Oh, those are my oversights. You are right! > I modified the patch as you pointed out.
Cool. This looks good to me now and I also tested it. I will commit it unless (a) someone objects or (b) someone else does it first. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
