Andrew Dunstan wrote: > > > Bruce Momjian wrote: > > Tom Lane wrote: > > > >> Why has pgindent decided to screw up all the FD_SET calls in our code? > >> See for example > >> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/pgstat.c.diff?r1=1.188;r2=1.189 > >> > > > > Because the typedef list supplied by Andrew includes FD_SET as a > > typedef. :-O See src/tools/pgindent/typedefs.list. > > > > I've committed a fix to pgindent for this. Do we want to rerun pgindent > for these files?: > > src/test/examples/testlibpq2.c > src/interfaces/libpq/fe-misc.c > src/backend/postmaster/syslogger.c > src/backend/postmaster/pgstat.c > src/backend/postmaster/postmaster.c > src/backend/replication/libpqwalreceiver/libpqwalreceiver.c > src/backend/port/win32/socket.c > src/backend/libpq/auth.c > contrib/pgbench/pgbench.c
Uh, I rarely run pgindent on individual files like this. If it is FD_SET you are worried about, I suggest we find all the FD_SET symbols and just remove the whitespace pgindent added and commit that. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
