On Wed, Apr 21, 2010 at 9:11 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Apr 21, 2010 at 1:56 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Robert Haas <robertmh...@gmail.com> writes: >>> ...shouldn't we move the "tests", plural, rather than just the one? >>> It seems right to reject new SR connections during shutdown. >> >> Yeah; you'd also need to adjust both of them to consider am_walsender. >> (IOW, we want to treat SR connections as non-superuser for both tests.) > > [ subject changed, recipient list trimmed ] > > Here's the fine patch. The actual code changes are simple and seem to > work as expected, but I struggled a bit with the phrasing of the > messages. Feel free to suggest improvements. Also, I wasn't sure if > there was somewhere in the documentation where we discussed the > restriction that only superusers can connect during shutdown. If > there is such a place, we should update that, too.
I have committed this as-is. We can further change the error messages if we like, but there didn't seem to be a clear consensus on any particular change from what I have here. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
