Alexander Korotkov escribió: > On Wed, May 12, 2010 at 11:04 PM, Alvaro Herrera > <alvhe...@alvh.no-ip.org>wrote: > > > On a quick look, I didn't like the way you separated the > > "pg_database_encoding_max_length() > 1" cases. There seem to be too > > much common code. Can that be refactored a bit better? > > > I did a little refactoring in order to avoid some similar code. > I'm not quite sure about my CHAR_CMP macro. Is it a good idea?
Well, since it's only used in one place, why are you defining a macro at all? -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
