On Thu, May 13, 2010 at 1:00 PM, Bruce Momjian <br...@momjian.us> wrote: > Is there a reason we require single quotes around boolean values in > recovery.conf? > > standby_mode = 'off' > > This does not work: > > standby_mode = off > > I knew there were inconsistencies between quoting in postgresql.conf and > recovery.conf, but I didn't realize it extended to boolean quoting. I > see this at the top of recovery.conf now: > > # This file consists of lines of the form: > # > # name = 'value' > # > # (The quotes around the value are NOT optional, but the "=" is.) > # > > and this issue existed in 8.4 as well. Seems I just never noticed it, > and it not specifically mentioned in the TODO item we already have.
I think we should add a TODO to parse recovery.conf with the same code we use to parse postgresql.conf, or possibly merge the two files. This issue was previously alluded to here: http://archives.postgresql.org/pgsql-hackers/2010-04/msg00211.php -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
