On Mon, 2010-05-31 at 20:11 +0900, Fujii Masao wrote: > On Thu, May 13, 2010 at 8:39 PM, Simon Riggs <sri...@postgresql.org> wrote: > > Log Message: > > ----------- > > Ensure that top level aborts call XLogSetAsyncCommit(). Not doing > > so simply leads to data waiting in wal_buffers which then causes > > later commits to potentially do emergency writes and for all forms > > of replication to be potentially delayed without need or benefit. > > Issue pointed out exactly by Fujii Masao, following bug report > > by Robert Haas on a separate though related topic. > > > > Modified Files: > > -------------- > > pgsql/src/backend/access/transam: > > xact.c (r1.290 -> r1.291) > > > > (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xact.c?r1=1.290&r2=1.291) > > This commit changed XLogSetAsyncCommitLSN() so that it's called > for abort case. So we need to change the comment of the function > as follows:
Agreed, will fix. Will also rename function to better document its new role. -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
