On Fri, 2010-06-25 at 17:25 +0300, Heikki Linnakangas wrote:
> On 25/06/10 16:11, Simon Riggs wrote:
> > Log Message:
> > -----------
> > Fix log_temp_files docs and comments to say bytes not kilobytes.
> > stat(2) field st_size returns bytes not kilobytes.
> > Bug found during recent performance tuning for PostgreSQL user.
> >
> > Modified Files:
> > --------------
> >      pgsql/doc/src/sgml:
> >          config.sgml (r1.282 ->  r1.283)
> >          
> > (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml?r1=1.282&r2=1.283)
> >      pgsql/src/backend/utils/misc:
> >          guc.c (r1.556 ->  r1.557)
> >          
> > (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.556&r2=1.557)
> 
> Hmm, GUC_UNIT_KB doesn't seem appropriate anymore. I'd suggest changing 
> the code to match the documentation instead.

Well, perhaps it does. Maybe I should fix the report to output KB
instead and revert all the comments to "kilo"

> Shouldn't this be backpatched, or was this a new bug in 9.0?

Spose so.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Development, 24x7 Support, Training and Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to