Robert Haas escreveu: > On Fri, Aug 20, 2010 at 11:05 AM, Euler Taveira de Oliveira > <eu...@timbira.com> wrote: >> Dmitriy Igrishin escreveu: >>> /* NOT presents - NULL. Why not "00000" ? */ >>> const char* sqlstate = Pg::PQresultErrorField(res, PG_DIAG_SQLSTATE); >>> >> That's because the protocol doesn't set error field when the command >> succeeded. IMHO it's an oversight (the documentation is correct but the code >> is not) and should be correct because the spec enforces it. > > Seems like a waste of bytes. > Ugh? It is a matter of correctness. I'm not arguing in favor of it but if we don't implement it, it is better document it. I don't actually rely on sql state to check errors but can have applications out there that expect the spec behavior but we don't provide it and, also fail to document it. Talking about the patch, it is just pqSaveMessageField() calls in *Complete messages. I can provide a patch for it.
-- Euler Taveira de Oliveira http://www.timbira.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
