2010/9/6 Itagaki Takahiro <itagaki.takah...@gmail.com>: > On Wed, Sep 1, 2010 at 1:29 PM, Pavel Stehule <pavel.steh...@gmail.com> wrote: >>> * %v also doesn't quote boolean values, but t and f are not valid. >>> You should use true and false (or 't' and 'f') for the cases. >> >> you have a true - it should be fixed > > I found quote_literal() prints boolean values as 'true' or 'false'. > It uses casting to text type rather than calling output function. > OTOH, format functions (and concat funcs) use output functions. > > Which should we use for such purposes? Consistent behavior is > obviously preferred. Boolean type might be the only type that > is converted to different representation in typoutput or cast-to-test, > but we should consider to have boolean-specific hardwired code, > or cast all types to text instead of output functions.
Personally I prefer casting to text - it allows some later customizations. And it's more consistent with || operator. So the functions concat* should to be fixed. Regards Pavel > > -- > Itagaki Takahiro > -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
