Brendan Jurd <dire...@gmail.com> writes:
> On 17 October 2010 09:59, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> Good point. Maybe the correct fix is to remember whether each token was
>> quoted or not, so that keyword detection can be done safely after the
>> initial lexing. I still think that the current method is impossibly
>> ugly ...
> I'm happy to revise the patch on that basis. Any suggestions about
> how to communicate the 'quotedness' of each token? We could make each
> token a struct consisting of the token itself, plus a boolean flag to
> indicate whether it had been quoted. Does that work for you?
Seems reasonable. I had the idea of a parallel list of booleans in the
back of my mind, but a list of structs is probably easier to understand,
and to extend further if necessary.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
