Itagaki Takahiro <itagaki.takah...@gmail.com> writes: > CREATE EXTENSION is interesting feature! > I just compiled it and tested it via SQL commands. Here is a quick > report.
Thanks for you time and interest! > * There are some compiler warnings. You might be missing something in > copyfuncs and equalfuncs. > ---- > copyfuncs.c:3119: warning: ‘_copyCreateExtensionStmt’ defined but not used > copyfuncs.c:3130: warning: ‘_copyDropExtensionStmt’ defined but not used > equalfuncs.c:1593: warning: ‘_equalCreateExtensionStmt’ defined but not used > equalfuncs.c:1602: warning: ‘_equalDropExtensionStmt’ defined but not used > postinit.c: In function ‘CheckMyDatabase’: > postinit.c:341: warning: implicit declaration of function ‘ExtensionSetCVC’ > ---- Ouch, sorry about that, I didn't spot them. Will fix and post a v4 patch soon. > * There might be some bugs in pg_dump: > ---- > postgres=# CREATE EXTENSION dblink; > NOTICE: Installing extension 'dblink' from > '$PGHOME/share/contrib/dblink.sql', with user data > CREATE EXTENSION > postgres=# \q > $ pg_dump > pg_dump: schema with OID 2200 does not exist, but is needed for object 16411 > ---- I've hit that sometime but though that were tied to the dependency bug fixed in the v3 patch. I can reproduce here, will fix too. > * The example in the doc "CREATE EXTENSION hstore" dumps surprising > warning messages, > We would be better to avoid such messages, though it's not an issue > for EXTENSION. > ---- > WARNING: => is deprecated as an operator name > DETAIL: This name may be disallowed altogether in future versions of > PostgreSQL. > CONTEXT: SQL statement "/* contrib/hstore/hstore.sql.in */ > (followed by dumped script) > ---- I don't have a dumped script here, that maybe depends on verbosity options? > * Docs sql-createextension.html has two odd links: > ---- > See Also > DROP EXTENSION, Table 9-61, Appendix F > ---- I didn't know if using xref would do, but if you find that odd, I will replace with linkend and a custom label there. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers