2010/12/17 Tom Lane <t...@sss.pgh.pa.us>: > Pavel Stehule <pavel.steh...@gmail.com> writes: >> This patch remove redundant rows from PL/pgSQL executor (-89 lines). >> Doesn't change a functionality. > > I'm not really impressed with this idea: there's no a priori reason > that all those loop types would necessarily have exactly the same > control logic. >
this code processes a rc from EXIT, CONTINUE and RETURN statement. All these statements are defined independent to outer loops, so there are no reason why this code has be different. And actually removed code was almost same. There was different a process for FOR statement, because there isn't possible direct "return" from cycle, because is necessary to release a allocated memory. There is no reason why the processing should be same, but actually is same. > regards, tom lane > -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
