On Fri, Dec 17, 2010 at 02:00, Dimitri Fontaine <dimi...@2ndquadrant.fr> wrote: > So, attached patch fixes the v18 regression wrt to script file encoding > and establish UTF-8 as the default encoding to consider to read a script > file. Thanks for your comments.
You probably compared wrong versions of source trees. The patch contains many diffs not related to EXTENSION. It cannot be applied cleanly. BTW, only earthdistance.sql.in has @extsch...@. Didn't you forget to remove it? --- b/contrib/earthdistance/earthdistance.sql.in ! SET search_path = @extschema@; I've not read the patch well yet, but I'd like to make sure of two specs in the patch: #1. I found the patch specifies "version" in each control file. We will need to maintain them manually, but I assume it was a conclusion in the discussion for v18 patch. So, no more changes are required here. --- b/contrib/XXX/XXX.control + version = '9.1devel' #2. The patch replaces "\i XXX.sql" to "CREATE EXTENSION XXX". They are a bit different because CREATE EXTENSION uses the installed sql files instead of the source directory. But I think this is the correct behavior. We should have used only installed files because they are used in "make *installcheck*". *** a/contrib/XXX/sql/XXX.sql *************** SET client_min_messages = warning; ! \set ECHO none ! \i XXX.sql ! \set ECHO all RESET client_min_messages; --- 7,13 ---- SET client_min_messages = warning; ! CREATE EXTENSION XXX; RESET client_min_messages; -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
