On Sun, Dec 26, 2010 at 12:17 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Proposed patch attached. This adds what I believe to be the correct >> incantations to errcodes.sgml and plerrcodes.h, and also corrects a >> typographical error in yesterday's commit which I failed to notice >> while reviewing. > > Hmm. Even with the typo fixed, ERRCODE_FDW_UNABLE_TO_CREATE_EXECUTION > seems pretty darn opaque. Is it missing a word? Can we rephrase it so > people will have some idea what it means?
(looks at a draft copy of the spec) Appears to be straight out of the spec. There's also some incomprehensible (to me) language explaining what it's supposed to mean. I think they're using the term "FDW execution" to mean something along the lines of "an instance of grabbing data via an FDW". Or something sort of vaguely like that. If I didn't know better I'd think this had been deliberately obfuscated. At any rate, I think rewording language straight out of the spec is likely a bad plan. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
