Greetings, * Peter Geoghegan (peter.geoghega...@gmail.com) wrote: > I do this all the time. Anyway, I intend for this doc patch to be > backported to 8.4 as a bugfix, which is part of the reason why it > isn't invasive - it's just a clarification. Clearly if it makes sense > for 9.1, it makes just as much sense for 9.0 and 8.4.
I agree with the patch, in general, as well as the recommendation to
back-port it. I reviewed it and didn't find any issues (though I
couldn't figure out the right magic things to install to actually build
the docs.. :( ). The only minor change I made was to capitalize Common
Table Expressions (having it as an acronym w/o capitalizing the full
name seemed odd to me..).
Updated patch attached. Marking as ready for committer.
commit 91e9e9285752c9fbe0c222708a10a301731594c8
Author: Stephen Frost <sfr...@snowman.net>
Date: Wed Jan 19 20:56:44 2011 -0500
Update WITH documentation to capitalize acronym
Common Table Expressions, being a 'proper' name and having an
acronym associated with them, really should be capitalized. This
patch makes that change in the WITH documentation.
commit 9e4565cc97b81fd6b3f96d8e346bcb7ee6e8878e
Author: Stephen Frost <sfr...@snowman.net>
Date: Wed Jan 19 20:54:47 2011 -0500
Add CTE as an acryonym and clarify WITH docs
This patch adds CTE to the list of acronyms and then updates the
WITH documentation to note that WITH queries are also known as
CTEs.
Patch by Peter Geoghegan
Thanks,
Stephen
*** a/doc/src/sgml/acronyms.sgml
--- b/doc/src/sgml/acronyms.sgml
***************
*** 99,104 ****
--- 99,113 ----
</varlistentry>
<varlistentry>
+ <term><acronym>CTE</acronym></term>
+ <listitem>
+ <para>
+ <link linkend="queries-with">Common Table Expression</link>
+ </para>
+ </listitem>
+ </varlistentry>
+
+ <varlistentry>
<term><acronym>CVE</acronym></term>
<listitem>
<para>
*** a/doc/src/sgml/queries.sgml
--- b/doc/src/sgml/queries.sgml
***************
*** 1525,1531 **** SELECT <replaceable>select_list</replaceable> FROM <replaceable>table_expression
<sect1 id="queries-with">
! <title><literal>WITH</literal> Queries</title>
<indexterm zone="queries-with">
<primary>WITH</primary>
--- 1525,1531 ----
<sect1 id="queries-with">
! <title><literal>WITH</literal> Queries (Common Table Expressions)</title>
<indexterm zone="queries-with">
<primary>WITH</primary>
***************
*** 1539,1545 **** SELECT <replaceable>select_list</replaceable> FROM <replaceable>table_expression
<para>
<literal>WITH</> provides a way to write subqueries for use in a larger
! query. The subqueries can be thought of as defining
temporary tables that exist just for this query. One use of this feature
is to break down complicated queries into simpler parts. An example is:
--- 1539,1546 ----
<para>
<literal>WITH</> provides a way to write subqueries for use in a larger
! query. The subqueries, which are often referred to as Common Table
! Expressions or <acronym>CTE</acronym>s, can be thought of as defining
temporary tables that exist just for this query. One use of this feature
is to break down complicated queries into simpler parts. An example is:
signature.asc
Description: Digital signature
