On Tue, Jan 25, 2011 at 10:32, Fujii Masao <masao.fu...@gmail.com> wrote: > On Mon, Jan 24, 2011 at 7:41 AM, Magnus Hagander <mag...@hagander.net> wrote: >> Make walsender options order-independent >> >> While doing this, also move base backup options into >> a struct instead of increasing the number of parameters >> to multiple functions for each new option. > > When I read the include-WAL-in-backup patch, I found that this > commit had the bug; parse_basebackup_options fails in parsing > options because of wrong usage of MemSet. Here is the patch.
Wow. I know I fixed that at one point, it must've gone bad again in a merge. Interestingly enough it works in my environment, but that must be pure luck. So thanks - applied. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers