On 25.01.2011 06:02, Fujii Masao wrote:
On Tue, Jan 25, 2011 at 6:02 AM, Heikki Linnakangas
<heikki.linnakan...@enterprisedb.com> wrote:
Hmm, perhaps the code would be more readable if instead of the
forcePageWrites counter that counts exclusive and non-exclusive backups, and
an exclusiveBackup boolean indicating if one of the in-progress backups is
an exclusive one, we had a counter that only counts non-exclusive backups,
plus a boolean indicating if an exclusive backup is in progress in addition
to them.
Attached is a patch for that (against master branch, including only xlog.c).
I read this patch and previous-posted one. Those look good.
Comments:
+ * do_pg_start_backup is the workhorse of the user-visible pg_stop_backup()
+ * function.
Typo: s/do_pg_start_backup/do_pg_stop_backup
It's helpful to explain about this behavior in pg_basebackup.sgml or elsewhere.
Thanks. I've committed this now, fixing that, and hopefully all the
other issues mentioned in this thread.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
