On Mon, 2011-01-31 at 19:12 -0500, Tom Lane wrote: > Robert Haas <robertmh...@gmail.com> writes: > > On Mon, Jan 31, 2011 at 6:07 PM, Simon Riggs <si...@2ndquadrant.com> wrote: > >> I would make ERRCODE_DATABASE_DROPPED an Invalid Authorization error, > >> rather than a Transaction Rollback code. So sqlstate 28P02 > > > ISTM it should still be in class 40. There's nothing wrong with the > > user's authorization; we've just decided to roll back the transaction > > for our own purposes. > > I agree, 28 is a completely off-point category. But it wasn't in 40 > before, either --- we are talking about where it currently says > ADMIN_SHUTDOWN, no? I'd vote for keeping it in class 57 (operator > intervention), as that is both sensible and a minimal change from > current behavior.
Sorry about that chaps, didn't see your emails: I just committed. 57 was another one I considered, as was 08 connection failures. I don't think 40 was the right place, but my bed was calling. I'll sleep now and fix in my morning according to what y'all decide. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
