On Sun, Feb 6, 2011 at 23:31, Stephen Frost <sfr...@snowman.net> wrote: > * Itagaki Takahiro (itagaki.takah...@gmail.com) wrote: >> I think we need to improve postgresql.conf.sample a bit more, especially >> the long line for #log_csv_fields = '...'. 330 characters in it! >> #1. Leave the long line because it is needed. > It's needed to match what the current default is..
I agree that it's logically good design, but we could not accept it as long as it breaks tools in the real world... Will it break "SHOW ALL" and "SELECT * FROM pg_settings" output? I'm worried that they are not designed to display such a long value. >> I think it depends default log filename, that contains %S (seconds) >> suffix. We can remove %S from log_filename; if we use a log per-day, >> those log might contain different columns even after restart. If we >> cannot avoid zigged csv fields completely, SIGHUP seems reasonable for it. > > This problem is bigger than SIGHUP, but at least with a restart > required, the default will work properly. The default configuration > wouldn't work w/ a change to the log line and a SIGHUP done. "Only works with the default settings" is just wrong design. If we cannot provide a perfect solution, we should allow users to control everything as they like. I still think PGC_SIGHUP is the best mode for the parameter, with a note of caution in the docs. -- Itagaki Takahiro -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers