On Tue, Feb 8, 2011 at 10:33, Alex Hunsaker <bada...@gmail.com> wrote: > On Tue, Feb 8, 2011 at 08:18, Alexey Klyukin <al...@commandprompt.com> wrote: >> Thanks, looks great to me. It passes all the tests on my OS X system. I >> wonder >> what's the purpose of the amagic_call in get_perl_array_ref, instead of >> calling newRV_noinc on the target SV * ? > > Well, you can't AV *av = (AV *)SvRV(sv); And the SV * amagic_call > returns is already a reference, so the newRV_noinc() would be > redundant no? It occurs to me instead of doing the amagic_call we > could just call the to_array method directly using perl_call_pv(). > That would look more normal and less magic-- thats probably a good > thing?
Err, even simpler would be to just access the 'array' member directly out of the hash object. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
