On Tue, Feb 1, 2011 at 1:33 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Feb 1, 2011 at 1:09 PM, Peter Eisentraut <pete...@gmx.net> wrote: >> On tis, 2011-01-18 at 19:24 -0500, Steve Singer wrote: >>> However if I connect with a line in pg_hba that matches on an IP >>> network then my client_hostname is always null unless log_hostname is >>> set to true. This is consistent with the behavior you describe but I >>> think the average user will find it a bit confusing. Having a column >>> that is always null unless a GUC is set is less than ideal but I >>> understand why log_hostname isn't on by default. >> >> Well, we have all these track_* variables, which also control what >> appears in the statistics views. >> >> After thinking about this some more, I think it might be better to be >> less cute and forget about the interaction with the pg_hba.conf hostname >> behavior. That is, the host name is set if and only if log_hostname is >> on. > > +1 for doing it that way.
I think there are no outstanding issues with this patch of any significance, so I'm marking it Ready for Committer. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
