On Tue, Mar 8, 2011 at 12:04 PM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Wed, Feb 9, 2011 at 5:12 PM, Magnus Hagander <mag...@hagander.net> wrote: >> I was also worried about the non-hot-standby case, but I see that the >> patch makes sure you can't enable pause when not in hot standby mode. >> Which in itself might be surprising - perhaps we need a NOTICE for >> when that happens as well? > > I didn't include this fix in the patch because I prefer FATAL to > NOTICE for that. > NOTICE doesn't stop recovery. So we might be unable to notice such a NOTICE > message and stop the recovery before it's too late, i.e., the recovery has > completed at the undesirable point. So I think that emitting FATAL is safer.
I included this fix in the patch, which emits FATAL if pause_at_recovery_target is enabled while hot standby is disabled and the recovery target is set. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
change_recovery_conf_sample_v3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
