On Thu, Mar 10, 2011 at 10:59 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >>>>> Speaking of running scripts, I think we should run pgindent now. > >> Yeah, +1 for doing it as soon as Tom is at a good stopping point. It >> makes things a lot simpler later on. > > IIRC the argument for an early pgindent run was to standardize the new > code for easier review. I expect to be spending a whole lot of time > reading collate and SSI code over the next few weeks, so I'm in favor > of pgindent'ing that stuff first. But I guess we need the typedef > list update before anything can happen.
That's one good reason. Another is that this is presumably the time of the cycle when there are the fewest outstanding patches, making it a good time for changes that are likely to conflict with lots of other things. At any rate, it sounds like Andrew needs a few days to get the typedef list together, so let's wait for that to happen and then we'll see where we are. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
