Bruce Momjian wrote: > Christopher Browne wrote: > > On Fri, Mar 11, 2011 at 12:50 PM, Bruce Momjian <br...@momjian.us> wrote: > > > It has bothered me that many of our time routines use special magic > > > constants for time values, e.g. 24, 12, 60, etc. > > > > > > The attached patch changes these magic constants to macros to clarify > > > the code. ?I would like to apply this for 9.1 as a cleanup. > > > > The context diffs show off some references to 1901 and 2038... > > > > Here's a *possible* extension to this... > > > Interesting idea, but UTIME_MINYEAR/UTIME_MAXYEAR is only defined in > src/interfaces/ecpg/pgtypeslib/dt.h, and it seems odd to duplicate or > move them for just one use site.
We could move UTIME_MINYEAR/UTIME_MAXYEAR, but I don't see a common file they both currently include. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
