On Fri, Mar 18, 2011 at 4:51 PM, Kevin Grittner <kevin.gritt...@wicourts.gov> wrote: > Dan Ports <d...@csail.mit.edu> wrote: > >> I am surprised to see that error message without SSI's hint about >> increasing max_predicate_locks_per_xact. > > After reviewing this, I think something along the following lines > might be needed, for a start. I'm not sure the Asserts are actually > needed; they basically are checking that the current behavior of > hash_search doesn't change. > > I'm still looking at whether it's sane to try to issue a warning > when an HTAB exceeds the number of entries declared as its max_size > when it was created.
I don't see much advantage in changing these to asserts - in a debug build, that will promote ERROR to PANIC; whereas in a production build, they'll cause a random failure somewhere downstream. The HASH_ENTER to HASH_ENTER_NULL changes look like they might be needed, though. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
