On 30.03.2011 09:25, Fujii Masao wrote:
On Wed, Mar 30, 2011 at 11:39 AM, Fujii Masao<masao.fu...@gmail.com>  wrote:
On Wed, Mar 30, 2011 at 12:54 AM, Heikki Linnakangas
<heikki.linnakan...@enterprisedb.com>  wrote:
Hmm, why did we change that?

I'm not sure, but I guess that's because I missed the case where crash
recovery starts from the backup :(

It seems like a mistake, the database is not
consistent until you reach the backup stop location, whether or not you're
doing archive recovery. +1 for reverting that, and backpatching it as well.

Agreed.

Attached patch reverts that. Comments?

Looks good, committed.

We could also improve the error message. If we haven't reached the end-of-backup location, we could say something along the lines of:

ERROR: WAL ends before the end of online backup
HINT: Online backup must be ended with pg_stop_backup(), and all the WAL up to that point must be available at recovery.

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to