On 31/03/11 07:35, Heikki Linnakangas wrote: > On 30.03.2011 21:21, Jan Urbański wrote: >> Valgrind showed me the way. PFA a trivial patch to avoid leaking a >> PLyProcedure struct in inline blocks. > > Hmm, any reason the PLyProcedure struct needs to be allocated in > TopMemoryContext in the first place? Could you palloc0 it in a > shorter-lived context, or even better, just allocate it in stack?
Yeah, you're right, you can keep it on the stack. > PS. I don't think the volatile qualifier in 'proc' is in necessary. The > variable is not changed in PG_TRY-block. That always confuses me, but I guess you're right, the variable does not change, only the memory it points to. Cheers, Jan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
