Tom Lane wrote: > Bruce Momjian <br...@momjian.us> writes: > > Tom Lane wrote: > >> Now having said that, there seems to be a pgindent bug here too, in that > >> it's throwing a space into > >> > >> Buffer > >> RelationGetBufferForTuple(Relation relation, Size len, > >> Buffer otherBuffer, int options, > >> struct BulkInsertStateData * bistate) > >> > >> Whether BulkInsertStateData is flagged as a typedef or not, surely it > >> ought to understand that "struct BulkInsertStateData" is a type name. > > > Uh, I think we have this listed as a known bug at the top of the > > pgindent script: > > Hm. I guess the third observation is that in the current state of the > code, there's no very good reason to be using "struct" in > RelationGetBufferForTuple's prototype anyway, since the typedef is > declared right above it. Maybe we should just change that and not > risk fooling with pgindent.
Probably. :-( -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
