On Thu, May 12, 2011 at 1:22 AM, Peter Eisentraut <pete...@gmx.net> wrote: > On ons, 2011-05-11 at 18:36 -0400, Bruce Momjian wrote: >> Robert Haas wrote: >> > On Wed, May 11, 2011 at 2:18 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> > > Or you could just "unsetenv" instead of complaining. >> > >> > +1 for that. >> >> OK, the attached patch does this, but allows PGCLIENTENCODING to be >> passed in. The new output looks like: >> >> Performing Consistency Checks >> ----------------------------- >> ignoring libpq environment variable PGPORT > > I haven't tried it, but I suppose option.c will now make use of PGPORT > and then later you get that message that it was ignored?
Either way, it hardly seems necessary to emit a log message stating that you are unsetting an environment variable. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
