On Sun, Jun 5, 2011 at 10:21 AM, Gurjeet Singh <singh.gurj...@gmail.com> wrote: > On Sat, May 21, 2011 at 11:59 AM, Josh Kupershmidt <schmi...@gmail.com> > wrote:
> Tweaks applied, but omitted the C variable names as I don't think that adds > much value. Your rewordings are fine, but the the article "the" is missing in a few spots, e.g. * "uses \ir command" -> "uses the \ir command" * "to currently processing file" -> "to the currently processing file" * "same as \i command" -> "same as the \i command" I think "processing" is better (and consistent with the rest of the comments) than "processed" here: + * the file from where the currently processed file (if any) is located. > New version of the patch attached. Thanks for the review. I think the patch is in pretty good shape now. The memory leak is gone AFAICT, and the comments and documentation updates look good. Josh -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
