On Wed, Jun 15, 2011 at 10:55 AM, Leonardo Francalanci <m_li...@yahoo.it> wrote: >> > On Wed, May 25, 2011 at 3:05 PM, Simon Riggs <si...@2ndquadrant.com> > wrote: >> > Leonardo, can you submit an updated version of this patch today that >> > incorporates Simon's suggestion? > > > Mmmh, maybe it was simpler than I thought; I must be > missing something... patch attached
No, I think it is that simple. Patch looks OK on initial eyeball. More detailed review to follow. With regards to the naming, I think it would be better if we kept XLOG_XACT_COMMIT record exactly as it is now, and make the second record an entirely new record called XLOG_XACT_COMMIT_FASTPATH. That way we retain backwards compatibility. If you'd like to rework like that please, otherwise I can take it from here if you'd like. > How can I test it with "weird" stuff as subtransactions, shared > cache invalidation messages...? make installcheck should cover those. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
