Robert Haas <robertmh...@gmail.com> writes: > On Fri, Aug 19, 2011 at 9:59 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> This patch seems unnecessary to me.
> Hmm. I see now that it's parallel, but I find it pretty confusing > that building sepgsql without specifying --with-selinux results in a > shared library that seems to compile OK but won't load. Well, that's a fair point, but the same happens in contrib/xml2 (if you have a setup that doesn't need a special -I switch, or you provide that some other way), and nobody has ever complained about it. > Why not just: > SHLIB_LINK = -lselinux I wouldn't have any particular objection to that (although I think it's supposed to be += here). I don't see that any of the other changes Kaigai proposed are helpful, though. > Similarly, in the case of xml2 we have: > SHLIB_LINK += $(filter -lxslt, $(LIBS)) $(filter -lxml2, $(LIBS)) > For xslt, it probably makes sense to filter it out if it wasn't found, > because the code has ifdefs for USE_XSLT that do something sensible if > the library is not there. But I fail to see what the point is of > filtering out xml2, because surely we're doomed if that's not there... > or am I confused? Hmm. I think it's just that way to make the code look parallel for both libraries. But I can see potential value in making -lxml2 unconditional --- as you say, that would result in a link failure instead of a silently broken library. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers