On Thu, Sep 8, 2011 at 10:29 AM, Bruce Momjian <br...@momjian.us> wrote: > Tom Lane wrote: >> Simon Riggs <si...@2ndquadrant.com> writes: >> > On Wed, Sep 7, 2011 at 9:02 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> >> Simon Riggs <si...@2ndquadrant.com> writes: >> >>> Please lets not waste effort on refactoring efforts in mid dev cycle. >> >> >> Say what? When else would you have us do it? >> >> > When else would you have us develop? >> >> In my eyes that sort of activity *is* development. I find the >> distinction you are drawing entirely artificial, and more calculated to >> make sure refactoring never happens than to add any safety. Any >> significant development change carries a risk of breakage. > > I ran pgrminclude a week ago and that is certainly a larger change than > this. Early in the development cycle people are merging in their saved > patches, so now is a fine time to do refactoring.
+1. I'd feel more comfortable refactoring it if we had some automated testing of those code paths, but I don't see anything wrong with doing it now from a timing perspective. We still have 4 months until the start of the final CommitFest. I wouldn't be too enthusiastic about starting a project like this in January, but now seems fine. A bigger problem is that I don't hear anyone volunteering to do the work. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers