Christopher Kings-Lynne wrote: > > > I am thinking of rolling back my CVS to see if there's code from your > > > previous test implementation that we can use. Apart from the DropColumn > > > function itself, what other changes did you make? Did you have > > > modifications for '*' expansion in the parser, etc.? > > > > Yes, please review Hiroshi's work. It is good work. Can we have an > > analysis of Hiroshi's approach vs the isdropped case. > > Yes, it is. I've rolled it back and I'm already incorporating his changes > to the parser into my patch. I just have to grep all the source code for > 'HACK' to find all the changes. It's all very handy.
Yes. It should have been accepted long ago, but we were waiting for a "perfect" solution which we all know now will never come. > > > Is it better to renumber the attno or set a column to isdropped. The > > former may be easier on the clients. > > Well, obviously I prefer the attisdropped approach. I think it's clearer > and there's less confusion. As a head developer for phpPgAdmin that's what > I'd prefer... Hiroshi obviously prefers his solution, but doesn't object to OK, can you explain the issues from a server and client perspective, i.e. renumbering vs isdropped? -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 ---------------------------(end of broadcast)--------------------------- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/users-lounge/docs/faq.html