On Wed, Nov 2, 2011 at 4:44 AM, Simon Riggs <si...@2ndquadrant.com> wrote: > Patch removes stuff related to "startup process" and creates files > under src/$DIR/postmaster for this code. > > This makes startup process look more like bgwriter, walwriter etc..
In general, +1. But I don't think we want duplicate function prototypes for the same functions, so -1 for this hunk: + /* in xlog.c */ + extern void WakeupRecovery(void); + extern void StartupXLOG(void); The existing prototypes in xlog.h seem like they should be just fine. IsPromoteTriggered could be simplified to just "return promote_triggered;"; you don't need to branch. I think one thing that would be worth considering in terms of future refactoring is to split up the gigantic StartupXLOG() function in some fashion. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
