On Thu, Nov 3, 2011 at 10:18 AM, Dimitri Fontaine <dimi...@2ndquadrant.fr> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> Hmm, I was kind of expecting that to be wrong at least in some minor way. > >> +/* contrib/hstore/hstore-1.0-1.1.sql */ >> + >> +-- complain if script is sourced in psql, rather than via CREATE EXTENSION >> +\echo Use "ALTER EXTENSION hstore" to load this file. \quit > > You could mention ALTER EXTENSION hstore UPDATE TO 1.1; in this comment, > I think. > >> +++ b/contrib/hstore/hstore--1.1.sql >> @@ -0,0 +1,524 @@ >> +/* contrib/hstore/hstore--1.0.sql */ > > That needs a comment update too.
Thanks for the review. New version attached. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
hstore-drop-arrow-v3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
