2011/12/10 Greg Smith <g...@2ndquadrant.com>: > On 11/30/2011 10:42 AM, Pavel Stehule wrote: >> >> Regress tests are really large - it is question if about 900 lines is >> necessary - should be more compact >> > > > Can't recall the last time I heard a complaint about having too many > regression tests for new code. We've got some bit rot, code convention > suggestions, test scope concerns, and some fundamental design questions > hanging over this one. I don't think anyone expected this TODO item was > going to turn into a 2626 line patch, but discovering a bunch of unexpected > complexity underneath one of those is a regular event. Stuff that's > straighforward to implement tends to just get done instead of added there. > this is just my opinion, it's not blocker (about regress tests length)
but maybe this patch should be divided to some smaller parts Regards Pavel > Tom's concerns about the grammar rewrite and way parsing is handled here > seem the worst blockers for committing this, and I can't imagine how those > could be resolved before this CommitFest is over. I'm going to mark this > one as returned with that and Pavel's feedback. Perhaps Wojciech or someone > else will come up with a clever way to address this, one that has less > impact on existing code. Adding more parser complexity than absolutely > necessary is a much bigger problem than the regression tests being too long. > > -- > Greg Smith 2ndQuadrant US g...@2ndquadrant.com Baltimore, MD > PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.us > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
