On 01/03/2012 06:29 PM, Peter Eisentraut wrote:

I think there is some room for improvement there:

- Why is the isolation test not part of check-world/installcheck-world?

The buildfarm does not use the -world targets, for several reasons,
including:
That was not my question.  I run check-world/installcheck-world locally,
and if the isolation test had been part of this, this problem wouldn't
have happened.


I have no idea why. It was probably an oversight when the isolation tests were added. I guess something like this would fix it?

   diff --git a/GNUmakefile.in b/GNUmakefile.in
   index 50fae41..5976832 100644
   --- a/GNUmakefile.in
   +++ b/GNUmakefile.in
   @@ -68,7 +68,7 @@ check installcheck installcheck-parallel:

   $(call recurse,check-world,src/test src/pl src/interfaces/ecpg
   contrib,check)

   -$(call recurse,installcheck-world,src/test src/pl
   src/interfaces/ecpg contrib,installcheck)
   +$(call recurse,installcheck-world,src/test src/test/isolation
   src/pl src/interfaces/ecpg contrib,installcheck)

   $(call recurse,maintainer-check,doc src config contrib)


The isolation tests only run installcheck, not plain check. See the archives for details of why.


- Could we get the buildfarm server to send out emails whenever a build
fails?
This facility has been there for years
Cool, maybe it could be advertised on buildfarm.postgresql.org.  I
couldn't see any link leading from there to anywhere near the mailing
lists.




OK, I'll look at providing links from the web site to the lists.

cheers

andrew


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to