I found that I needed to adjust the command given in the README file
for pgindent.  Trivial patch attached.
 
The one other issue I ran into in following the latest pgindent
instructions was that I had to add #include <stdlib.h> to the
parse.c file (as included in the pg_bsd_indent-1.1.tar.gz file at
ftp://ftp.postgresql.org/pub/dev ).  Without it I got this:
 
parse.c: In function *parse*:
parse.c:236:6: warning: implicit declaration of function *exit*
parse.c:236:6: warning: incompatible implicit declaration of built-in
function *exit*
 
Can someone fix that and put up a 1.2 version?
 
-Kevin

diff --git a/src/tools/pgindent/README b/src/tools/pgindent/README
index d88c201..a47b809 100644
--- a/src/tools/pgindent/README
+++ b/src/tools/pgindent/README
@@ -22,7 +22,7 @@ This can format all PostgreSQL *.c and *.h files, but 
excludes *.y, and
 
        find . -name '*.[ch]' -type f -print | \
        egrep -v -f src/tools/pgindent/exclude_file_patterns | \
-       xargs -n100 pgindent src/tools/pgindent/typedefs.list
+       xargs -n100 src/tools/pgindent/pgindent src/tools/pgindent/typedefs.list
 
 6) Remove any files that generate errors and restore their original
    versions.
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to