Hi,

I just spotted that tab completion of double quoted identifiers seems
to be broken in 9.2devel. For example things like this which worked in
9.1 no longer work:

UPDATE "foo bar" <tab>

It looks like the problem is in get_previous_words() here:

                if (buf[start] == '"')
                    inquotes = !inquotes;
                else if (!inquotes)
                {
                    ... test for start of word ...

which fails to account for the fact that the double quote itself might
be the start of the word. I think the solution is just to remove the
"else":

                if (buf[start] == '"')
                    inquotes = !inquotes;
                if (!inquotes)
                {
                    ... test for start of word ...

to allow it to find a word-breaking character immediately before the
double quote.

Regards,
Dean

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to