On 04/05/2012 04:27 PM, Simon Riggs wrote:
It's shocking since after months of work and an especially extended edition CF, we expect people to deliver something, not just shunt the whole thing off as rejected with 1 days's notice to alter that outcome.
I don't think this is being fair to Robert. You agreed with the hard deadline last week. And the fact that the CF is late isn't a good reason to say it's OK for it to be more late. Every patch that had been reviewed but still had problems has been on life support the entire month of March. The surprising part isn't when one of them is finally returned, it's that they were still alive at all.
The theory here is supposed to be that large patches show up in the next to last CF, and by the time they hit the last one they're close to being ready. Just since the beginning of March, Command Triggers picked up useful feedback from all three listed reviewers (plus other commentary and related committer work), going through six revisions. There was still rippling impact like the CTAS/SELECT INTO utility command work going on six weeks into the CF.
The way Dimitri has been updating something this large so often makes me dizzy, and I think everyone is disappointed that we haven't seen any great subsets of this separate out to focus on. But regardless of who's right or wrong about what's left to do, any objective look at this one would say it's surely not settled down. And the bar at this point here in April isn't "is this an important feature?" anymore. It should be "is this such an important feature that it's worth delaying the release and taking a risk on recently churning code for?" Let's not kill the messenger who delivers that reminder just because the news is painful.
-- Greg Smith 2ndQuadrant US g...@2ndquadrant.com Baltimore, MD PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
