On Fri, Jun 1, 2012 at 10:51 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Jun 1, 2012 at 8:47 AM, Florian Pflug <f...@phlo.org> wrote: > >> We'd drain the unpin queue whenever we don't expect a PinBuffer() request >> to happen for a while. Returning to the main loop is an obvious such place, >> but there might be others. > > However, on a workload like pgbench -S, dropping the pin when you > return to the main loop would render the optimization useless.
But do we need the optimization on a workload like pgbench -S? You did some pretty massive scalability tests on that front, and I don't think this problem was identified in them. Cheers, Jeff -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
