On Sun, Jun 10, 2012 at 08:55:13PM -0400, Alvaro Herrera wrote:
> 
> Excerpts from Bruce Momjian's message of dom jun 10 15:20:34 -0400 2012:
> > Run pgindent on 9.2 source tree in preparation for first 9.3
> > commit-fest.
> 
> Hm, does this touch stuff that would also be modified by perltidy?  I
> wonder if we should refrain from doing entab/detab on perl files and
> instead have perltidy touch such code.
> 
> > src/tools/msvc/Install.pm                       | 1056 ++++++++++---------
> > src/tools/msvc/MSBuildProject.pm                |  325 +++---
> > src/tools/msvc/Mkvcbuild.pm                     | 1278 
> > ++++++++++++-----------
> > src/tools/msvc/Project.pm                       |  607 ++++++------
> > src/tools/msvc/Solution.pm                      |  980 +++++++++---------
> > src/tools/msvc/VCBuildProject.pm                |  292 +++---
> > src/tools/msvc/VSObjectFactory.pm               |  152 ++--
> > src/tools/msvc/build.pl                         |   20 +-
> > src/tools/msvc/builddoc.pl                      |   32 +-
> > src/tools/msvc/config_default.pl                |   38 +-
> > src/tools/msvc/gendef.pl                        |   66 +-
> > src/tools/msvc/install.pl                       |    4 +-
> > src/tools/msvc/pgbison.pl                       |   14 +-
> > src/tools/msvc/pgflex.pl                        |   60 +-
> > src/tools/msvc/vcregress.pl                     |  400 ++++----

The Perl files were modified by perltidy and not by pgindent, as
documented in the pgindent README:

        9) Indent the Perl MSVC code:
        
                cd src/tools/msvc
                perltidy -b -bl -nsfs -naws -l=100 -ole=unix *.pl *.pm

> Perhaps the thing to do is ensure that perltidy also uses tabs instead
> of spaces.

If you would like 'entab' run on the Perl files, let me know.

-- 
  Bruce Momjian  <br...@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to