Excerpts from Alex Hunsaker's message of jue jun 21 10:27:41 -0400 2012: > > On Wed, Jun 20, 2012 at 1:15 PM, Alvaro Herrera > <alvhe...@commandprompt.com> wrote: > > Excerpts from Alex Hunsaker's message of vie feb 10 16:53:05 -0300 2012: > > > >> Seems like we missed the fact that we still did SvUTF8_on() in sv2cstr > >> and SvPVUTF8() when turning a perl string into a cstring. > > > > Right. > > > > So I played a bit with this patch, and touched it a bit mainly just to > > add some more comments; and while at it I noticed that some of the > > functions in Util.xs might leak some memory, so I made an attempt to > > plug them, as in the attached patch (which supersedes yours). > > I think most of these leaks go back to 9.0. Dunno if its worth > backpatching them...
Well, nobody has ever complained about them so maybe they're just not worth the effort. > > to test the problem in the original report, I notice that we now have a > > regression failure: > > > I'm not really sure what to do here -- maybe have a second expected file > > for that test is a good enough answer? Or should I just take the test > > out? Opinions please. > > I think we have broken that check twice so it seems like it would be > nice to keep. But I don't feel *to* strongly about it. Hmm, if we're broken it then it's probably best to keep it. > The comment and cleanups all look good to me. Thanks for the review. -- Álvaro Herrera <alvhe...@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
