Hi, On Monday, July 02, 2012 04:19:56 PM Peter Geoghegan wrote: > The first thing I noticed about the patch was that inline functions > are used freely. While I personally don't find this unreasonable, we > recently revisited the question of whether or not it is necessary to > continue to support compilers that do not support something equivalent > to GNU C inline functions (or that cannot be made to support them via > macro hacks). The outcome of that was that it remains necessary to use > macros to provide non-inline equivalent functions. For a good example > of how that was dealt with quite extensively, see the sortsupport > commit: > > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=c6e3ac11b60ac > 4a8942ab964252d51c1c0bd8845 > > In particular, take a look at the new file sortsupport.h . I actually find sortsupport.h not to be a good example in general because it duplicates the code. Unless youre dealing with minor amounts of code playing macro tricks like I did in the ilist stuff seems to be a better idea.
Greetings, Andres -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
