On Thu, Jul 5, 2012 at 7:11 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Sun, Jul 1, 2012 at 5:11 AM, Alexander Korotkov <aekorot...@gmail.com> >> wrote: >>> [ new patch ] > >> With the improved comments in pg_wchar.h, it seemed clear what needed >> to be done here, so I fixed up the MULE conversion and committed this. >> I'd appreciate it if someone would check my work, but I think it's >> right. > > Hm, several of these routines seem to neglect to advance the "from" > pointer?
Err... yeah. That's not a bug I introduced, but I should have caught it... and it does make me wonder how well this code was tested. Does the attached look like an appropriate fix? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
wchar-advance-from.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
