On 10 July 2012 21:26, Alvaro Herrera <alvhe...@commandprompt.com> wrote: >> I haven't defined Relation in elog.h; I have pre-declared it there. >> Maybe that isn't to your taste, but there is surely something to be >> said for adding exactly one line of code in preference to adding an >> entire new header file, and having a bunch of existing files include >> that new header. > > That is true. I'd like to hear others' opinions.
It seems that the code, exactly as written, relies upon a GNU extension that didn't make it into the standard until C11 - the redefinition of a typedef. Clang warns about this. Still, it ought to be possible, if not entirely straightforward, to use a pre-declaration all the same. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
