Merlin Moncure <mmonc...@gmail.com> writes: > On Fri, Jul 20, 2012 at 1:31 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Here's a draft patch for that. It wasn't quite as ugly as I feared. >> A lot of the apparent bulk of the patch is because I chose to split >> ExecEvalVar into separate functions for the scalar and whole-row >> cases, which seemed appropriate because they now get different >> ExprState node types.
> Thanks for that! Applying the patch and confirming the fix turned up > no issues. I did a perfunctory review and it all looks pretty good: > maybe ExecInitExpr could use a comment describing the > InvalidAttrNumber check though...it's somewhat common knowledge that > InvalidAttrNumber means row variables but it's also used to initialize > variables before loops scans and things like that. Thanks for testing. I added the suggested comment and made some other cosmetic improvements, and have committed this. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers